Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-libs/gsl-2.4 version bump for issue #813 #815

Closed
wants to merge 1 commit into from

Conversation

kiwifb
Copy link
Contributor

@kiwifb kiwifb commented Sep 21, 2017

I also fixed https in all ebuild to keep repoman happy. However I didn't migrate 1.16 to EAPI 6 or from autotools-multilib.

Controversial bit: the use of fma instructions leads to failures in the testsuite. So I explicitly disable them if they are available. I cannot just filter them since -march=native will enable them when available.

…poman happy.

Package-Manager: Portage-2.3.8, Repoman-2.3.3
@heroxbd
Copy link
Contributor

heroxbd commented Sep 23, 2017

Could you please forward thism fma issue upstream?

@kiwifb
Copy link
Contributor Author

kiwifb commented Sep 23, 2017

I intend too, although I believe it to be fundamentally the same issue than something already opened since gsl-2.1 (IRC), it was reported for avx, which happens to enable fma where available as well. They probably can do something about the tolerance of that test. The tolerance code is incredibly nebulous to the newcomer otherwise I would have gone that way already.

@heroxbd
Copy link
Contributor

heroxbd commented Sep 23, 2017

Which gsl bug are you referring to? Let's point to the bug as a reference in the ebuild.

Probably this one https://savannah.gnu.org/bugs/?49697

Does that mean we should pass -mno-avx as well?

@kiwifb
Copy link
Contributor Author

kiwifb commented Sep 23, 2017

I am fairly sure it is a related issue to https://savannah.gnu.org/bugs/?49697 but I only have one discrepancy I believe. It is otherwise very similar I believe.

@kiwifb
Copy link
Contributor Author

kiwifb commented Sep 23, 2017

For -mno-avx I don't believe so. -mno-fma is more precise than -mno-avx. As in, you need avx to enable fma in the first place I think.

@kiwifb kiwifb deleted the gsl-2.4 branch October 16, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants