Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*/* misc fixes to make repoman happier #999

Closed
wants to merge 1 commit into from
Closed

*/* misc fixes to make repoman happier #999

wants to merge 1 commit into from

Conversation

AndrewAmmerlaan
Copy link
Member

  • http to https where possible
  • remove some blank lines
  • quote unquoted variables
  • '=' to '~' where applicable
  • add slot operator where necessary
  • correct one dependency that has been renamed in ::gentoo (dev-util/Hermes to dev-util/hermes)
  • fdo-mime to xdg-utils (fdo-mime has been removed from ::gentoo, functionality is identical)
  • clean up profiles/ (there's no need to keep a copy of arch.list or categories in ::sci if we are not adding arches or categories, it got out of date and lead to annoying warnings)
  • clean up licenses/ (remove licenses that are in ::gentoo, clean up license_groups)

This fixes most of the smaller trivial issues that repoman finds in this repository. Once these are fixed I might see about fixing some of the bigger non-trivial ones if I have the time.

Package-Manager: Portage-3.0.12, Repoman-3.0.2
Signed-off-by: Andrew Ammerlaan andrewammerlaan@riseup.net

@epsilon-0
Copy link
Contributor

Thanks so much !!
So, I fixed the hermes/Lmod things as they were in need of a few more complex changes (moving to slotted lua).

Could you remove those?
I'm still taking a look at the other things ❤️

@AndrewAmmerlaan
Copy link
Member Author

Could you remove those?

Removed.

RepoMan scours the neighborhood...
RDEPEND.suspect               2
sys-cluster/lmod/lmod-8.4.19.ebuild: 'virtual/pkgconfig'
sys-cluster/lmod/lmod-9999.ebuild: 'virtual/pkgconfig'

Should lmod RDEPEND on pkgconfig?

@epsilon-0
Copy link
Contributor

Could you remove those?

Removed.

RepoMan scours the neighborhood...
RDEPEND.suspect               2
sys-cluster/lmod/lmod-8.4.19.ebuild: 'virtual/pkgconfig'
sys-cluster/lmod/lmod-9999.ebuild: 'virtual/pkgconfig'

Should lmod RDEPEND on pkgconfig?

Yes, it uses pkg-config in scripts to mess around with LD_PRELOAD and LD_LIBRARY_PATH.

@epsilon-0
Copy link
Contributor

OK, so a quick glance makes it look fine.
We can try to split it up now, maybe one thing at a time, so first one that looks fine would be the license cleanup.
Could you create a PR for that?
That should be pretty easy to merge, only one package ebuild changes which uses CeCILL-2.0, rest are deletions and the license group cleanup.

@AndrewAmmerlaan
Copy link
Member Author

OK, so a quick glance makes it look fine.
We can try to split it up now, maybe one thing at a time, so first one that looks fine would be the license cleanup.
Could you create a PR for that?
That should be pretty easy to merge, only one package ebuild changes which uses CeCILL-2.0, rest are deletions and the license group cleanup.

Alrighty, this PR here only cleansup the licenses: #1000

@epsilon-0
Copy link
Contributor

Awesome, next can you do the profiles/* cleanup?
That one also looks straightforward enough to merge fast.

@AndrewAmmerlaan
Copy link
Member Author

AndrewAmmerlaan commented Dec 29, 2020

Awesome, next can you do the profiles/* cleanup?
That one also looks straightforward enough to merge fast.

PR for cleaning up profiles: #1001

@epsilon-0
Copy link
Contributor

Great I merged that.
The http -> https one is something that I'd like but at the same time... almost all those packages don't even fetch, regardless of http or https 😿
Well, at least adding those would make it somewhat easier to look for other errors, so we are not losing anything at least.

Can you rebase? I think the http to https is the only one remaining yea?

- http to https where possible
- remove some blank lines
- quote unqouted variables
- fdo-mime to xdg-utils
- clean up profiles/
- clean up licenses

Package-Manager: Portage-3.0.12, Repoman-3.0.2
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@riseup.net>
@AndrewAmmerlaan
Copy link
Member Author

AndrewAmmerlaan commented Dec 29, 2020

Great I merged that.
The http -> https one is something that I'd like but at the same time... almost all those packages don't even fetch, regardless of http or https crying_cat_face
Well, at least adding those would make it somewhat easier to look for other errors, so we are not losing anything at least.

My thoughts exactly, some of these packages are still broken, but now at the very least they are slightly less broken which makes it easier to find and fix other errors. Otherwise repoman spits out so many errors and warnings that we can no longer see the wood for the trees.

Can you rebase? I think the http to https is the only one remaining yea?

Rebased 😄

It's mostly http --> https now. I also fixed one manifest file, added a missing slot operator, and changed '=' to '~' once or twice. Only small trivial fixes.

@epsilon-0
Copy link
Contributor

Thanks a lot !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants