Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for #87: Test Github-Overleaf workflow #93

Merged
merged 3 commits into from
Nov 5, 2023

Conversation

ShiqiYang2022
Copy link
Collaborator

Closes #87.

In issue #87 we did small fix of the run_latex() in gslab_make, and set up the widescreen aspect ratio in slides.tex.

This PR is opened to review the changes, I suggest to re-run the template on their own end and see (1) whether it successfully compiles; (2) whether the the widescreen ratio is correctly set-up(16:9). I am requesting @jc-cisneros @snairdesai to conduct the review.

@ShiqiYang2022 ShiqiYang2022 linked an issue Nov 1, 2023 that may be closed by this pull request
@jc-cisneros
Copy link
Contributor

@ShiqiYang2022 in step (1), everything ran correctly (even doing it twice without manually clearing anything):

Version logs successfully written!
Executing command: `pdflatex -output-directory=../latex_auxiliary_dir  "/Users/jccp/Documents/template/paper_slides/code/paper.tex"`
Executing command: `pdflatex -output-directory=../latex_auxiliary_dir  "/Users/jccp/Documents/template/paper_slides/code/online_appendix.tex"`
Executing command: `pdflatex -output-directory=../latex_auxiliary_dir  "/Users/jccp/Documents/template/paper_slides/code/slides.tex"`
Output logs successfully written!
Ending makelog file at: `/Users/jccp/Documents/template/paper_slides/log/make.log`

Copy link
Contributor

@snairdesai snairdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShiqiYang2022: Confirming (1) above also works as expected on my end; and I believe the aspect ratio in (2) is now also properly maintained. Thanks for the work!

@jc-cisneros
Copy link
Contributor

Regarding (2), the slides seem to be in the correct ratio ($6.3:3.54 \approx 16:9$).

Copy link
Contributor

@jc-cisneros jc-cisneros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both (1) and (2) worked on my end. Thanks @ShiqiYang2022!

@ShiqiYang2022 ShiqiYang2022 merged commit 1f2d868 into master Nov 5, 2023
@ShiqiYang2022 ShiqiYang2022 deleted the issue87_workflow_test branch November 5, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Github-Overleaf workflow
3 participants