This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
Fix PR 183 #186
Merged
Fix PR 183 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storage and use $translate.uses()
| @@ -49,23 +49,21 @@ | |||
| var Layers = function() { | |||
| var promise; | |||
| var me = this; | |||
| var currentTopic; | |||
| var currentLang; | |||
| var currentTopicId; | |||
There was a problem hiding this comment.
This variable is never used, but it should be used!
|
We need to discuss these points when Eric is back from vacation (see #187) |
|
Addressed with #231. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#183
Use angular.isDefined. Fix huge mistake due to object. Remove lang storage and use $translate.uses()