Ensure that k8s client created from quarkus-kubernetes-config

Relates to: quarkusio#18973
geoand · Mar 21, 2023 · a990743 · a990743
1 parent 187ca4b
commit a990743
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/...me/src/main/java/io/quarkus/kubernetes/config/runtime/KubernetesConfigSourceProvider.java b/...me/src/main/java/io/quarkus/kubernetes/config/runtime/KubernetesConfigSourceProvider.java
@@ -23,6 +23,12 @@ class KubernetesConfigSourceProvider implements ConfigSourceProvider {
     private final ConfigMapConfigSourceUtil configMapConfigSourceUtil;
     private final SecretConfigSourceUtil secretConfigSourceUtil;
 
+    /**
+     * @param config Quarkus runtime Configuration of the extension
+     * @param buildTimeConfig Quarkus build-time Configuration of the extension
+     * @param client A Kubernetes Client that is specific to this extension - it must not be shared with any other parts of the
+     *        application
+     */
     public KubernetesConfigSourceProvider(KubernetesConfigSourceConfig config, KubernetesConfigBuildTimeConfig buildTimeConfig,
             KubernetesClient client) {
         this.config = config;
@@ -47,6 +53,7 @@ public Iterable<ConfigSource> getConfigSources(ClassLoader forClassLoader) {
         if (buildTimeConfig.secretsEnabled && config.secrets.isPresent()) {
             result.addAll(getSecretConfigSources(config.secrets.get()));
         }
+        client.close(); // we no longer need the client, so we must close it to avoid resource leaks
         return result;
     }