Swap AsyncHttpFileReader for HttpObjectStore #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntly in the default features list - best to explicitly specify features anyway)
kylebarron
approved these changes
Apr 12, 2024
Yes definitely.
Alas, we do need better code reuse, but right now I'm trying to focus on supporting GeoParquet (and GeoParquet 1.1 with spatial indexing), and later we can come back and improve code reuse between here and parquet-wasm. |
H-Plus-Time
force-pushed
the
object-store-wasm-usage
branch
from
093a1cb
to
1443825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly copied from the equivalent parquet-wasm PR 😛 .
I'm strongly considering just wrapping object_store_s3_wasm in object-store-wasm this weekend, so if there's no particular rush, I can work the coveted fsspec-like protocol-differentiated IO into this PR.
Also, one question for any maintainer -
io_parquet_asyncimplies object-store-wasm::http at a minimum, right? I'm thinking in terms of the other cloud providers, which I imagine would be worth feature-gating at the level of this consuming crate (it's a shame toggling transitive dependency features isn't a thing).