Update 07-reproj.Rmd #1060
Merged
Update 07-reproj.Rmd #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grammar
Robinlovelace
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Both could work but agree, commas are more conventional and appropriate here. I'd like to get your reasoning here @tibbles-and-tribbles but it's a general 👍 from me.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
…ch-38 Update 07-reproj.Rmd 9f99341
|
The word "set" definitely needs to be moved outside the clause, whether or not we use dashes or commas. My issue with the dashes is that they don't look good visually. They look sort of like long minus signs. |
|
👍 good explanation, thanks for your attention to detail 🧐 |
github-actions bot
pushed a commit
to defuneste/geocompr
that referenced
this pull request
Feb 1, 2024
…bles/patch-38 Update 07-reproj.Rmd 9f99341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grammar