Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to c5 #698

Merged
merged 10 commits into from
Dec 19, 2021
Merged

Updates to c5 #698

merged 10 commits into from
Dec 19, 2021

Conversation

Robinlovelace
Copy link
Collaborator

No description provided.

@Robinlovelace Robinlovelace changed the title Tweak c5 intro Updates to c5 Dec 18, 2021
@Robinlovelace Robinlovelace marked this pull request as ready for review December 19, 2021 11:39
@Robinlovelace
Copy link
Collaborator Author

Heads-up @Nowosad this is good to go. Looking at it, it's a long chapter. I think that splitting out the raster-vector interactions content into a new dedicated chapter could represent a quick win, it's a long chapter and the topic is so important as to merit it's own chapter IMO atm.

@Nowosad
Copy link
Member

Nowosad commented Dec 19, 2021

@Robinlovelace Yes -- I think that is a good idea. What do you think @jannes-m ?

@Robinlovelace
Copy link
Collaborator Author

Good stuff, I've created a new issue #706 on the topic. Will merge this now to keep things moving.

@Robinlovelace Robinlovelace merged commit 651c563 into main Dec 19, 2021
@jannes-m
Copy link
Collaborator

jannes-m commented Dec 19, 2021

Aside from reducing the length of chapter 5, it would be sensible to split out the raster-vector stuff into a new chapter simply because extracting values from a raster is not changing the geometry of an spatial object (and therefore strictly speaking it does not belong to c5) and because raster-vector operations are somehow special in any case.

@Robinlovelace Robinlovelace deleted the c5-v2-updates-rl branch December 19, 2021 21:43
@Robinlovelace
Copy link
Collaborator Author

Thanks for the comment Jannes, sounds like there's consensus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants