Update to v0.3.0 of llir/llvm. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of PR geode-lang#24, Geode switched to using an unmodified version of llir/llvm, as such the old copy of llvm is no longer needed.
There were two main changes of llir/llvm that required updates in Geode, namely: 1) The sanity type-checks proposed in llir/llvm#65 and added in PR llir/llvm#72. 2) The API update of NewLoad, NewStore, NewGetElementPtr which added a elemType argument in preparation for opaque pointer types of the official LLVM project (see llir/llvm#112). To resolve 1), an Equal method was added to StructType and SliceType of gtypes. To resolve 2) the element type was passed as the first argument to NewLoad, NewStore and NewGetElementPtr. Note, we've definitely noticed that working with user-defined types is difficult and does not work well with the extensive type-switching used in llir/llvm. The user-defined types (structs with names and slices) of Geode have been very helpful to get a better understanding of this limitation of llir/llvm. This has been outlined in llir/llvm#59 (comment) and we hope to get a better design for sumtypes to allow user-defined types, values, constants, instructions, etc. One step at the time :) I'm still very happy that you started the Geode project Nick as I've learnt a lot from it and continue to learn more. Wish you all the best and a most lovely start of the new year. Cheers, Robin
|
Oh, and just as a side-note, with this PR, all test cases of Geode are passing: |
|
Awesome! Really appreciate the work upgrading dependent projects whenever you change the dependency's API - really admirable! Happy new year to you as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two main changes of llir/llvm that required updates in Geode,
namely:
Type check NewStore operands llir/llvm#72.
a elemType argument in preparation for opaque pointer types of the
official LLVM project (see proposal: API change, add
elemTypeparameter togetelementptrconstructors llir/llvm#112).To resolve 1), an Equal method was added to StructType and SliceType of
gtypes.
To resolve 2) the element type was passed as the first argument to
NewLoad, NewStore and NewGetElementPtr.
Note, we've definitely noticed that working with user-defined types is
difficult and does not work well with the extensive type-switching used
in llir/llvm. The user-defined types (structs with names and slices) of
Geode have been very helpful to get a better understanding of this
limitation of llir/llvm. This has been outlined in llir/llvm#59 (comment)
and we hope to get a better design for sumtypes to allow user-defined
types, values, constants, instructions, etc.
One step at the time :)
I'm still very happy that you started the Geode project Nick as I've
learnt a lot from it and continue to learn more.
Wish you all the best and a most lovely start of the new year.
Cheers,
Robin