Fix bug in ReferenceState that shifted all arrays by one element if r… #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eading an older "reference" file
|
Just saw this -- will look this weekend. |
feathern
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eading an older "reference" file
I messed up in my previous fix of ReferenceState; I forgot about the two ints in the beginning of the binary 'reference' file, namely sig=314 and nr. So when I closed and reopened the file when handling an exception, the float arrays started in the wrong spot, meaning each ref.radius, ref.density, etc., had their first element from the array previous. This should be fixed by this commit, which reads in two ints after the 'reference' file is opened again.
Sorry about that!