Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref%dsdr should now be scalable by constant c_11 #489

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

illorenzo7
Copy link
Contributor

All terms in the PDEs have constants out front that can scale the terms, except for the reference entropy advection term f_14. This pull request would insert a new constant (c_11) that can scale ref%dsdr in the custom framework and takes on an appropriate value for the other reference_type's.

@feathern
Copy link
Contributor

feathern commented Dec 1, 2023

Hi Loren,
This looks good, and I think it's a good idea. Can you also add a small update to the documentation so that c11 is included there as well? Then I'll do a full review/merge etc.

-Nick

@illorenzo7
Copy link
Contributor Author

OK, c_11 should now be properly included in documentation. I also noticed nonzero dS/dr was still present for reference_type 3 (but it gets set to zero there) so I corrected that as well.

I realize I never put the general anelastic mode in the doc, I will do that in a separate pull request.

@feathern
Copy link
Contributor

feathern commented Dec 5, 2023

Thank's for updating the documentation. I'm almost good with this now, but have one small request. Can you remove the two debugging statements "got here" and "actually got here"? After that, I'll approve and merge.
-Nick

@feathern
Copy link
Contributor

feathern commented Dec 5, 2023

Actually, I'll do that in a separate PR momentarily just for expediency.

Copy link
Contributor

@feathern feathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@feathern feathern merged commit 158c55d into geodynamics:main Dec 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants