Hide files #1076
Closed
Hide files #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expected to break most tests, testing needs to wait on Timo to ensure that the tester will be able to handle the subdirectories
|
@tjhei -- please add the tag in a comment to run the tester once your tester is capable of it. |
| * @param comm MPI communicator, used to limit creation of directory to | ||
| * processor 0. | ||
| */ | ||
| void general_create_directory(std::string pathname, const MPI_Comm &comm); |
There was a problem hiding this comment.
why call the function general_? Why not just create_directory?
|
Please see #1086 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to #934.
Testing for this needs to wait on Timo to update the automated tester to handle tested output in subdirectories correctly.