Hide visualization files #1086
Merged
Hide visualization files #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tjhei
force-pushed
the
pr1076
branch
2 times, most recently
from
f3d8d85
to
70b15f5
Compare
Expected to break most tests, testing needs to wait on Timo to ensure that the tester will be able to handle the subdirectories
- rename function to create_directory - make message optional - make some of the messages silent
- .visit file had wrong paths - remove member vars introduced and hardcode solution/
|
ready to review. |
| * @param silent Print a nicely formatted message on processor 0 if set | ||
| * to true. | ||
| */ | ||
| void create_directory(std::string pathname, const MPI_Comm &comm, bool silent); |
There was a problem hiding this comment.
make first argument a const reference. break arguments onto separate lines
|
OK to merge yourself once the minor issues are cleared. |
bangerth
added a commit
to bangerth/aspect
that referenced
this pull request
Jul 14, 2016
geodynamics#1074 used the old directory structure in the tests/ subdirectories, but was pre-empted by geodynamics#1086 and so tests fail because the pull request still put output files into the old location, but the executable now places them into a different location. Fix this by moving a file to its now correct location.
bangerth
added a commit
to bangerth/aspect
that referenced
this pull request
Jul 14, 2016
geodynamics#1074 used the old directory structure in the tests/ subdirectories, but was pre-empted by geodynamics#1086 and so tests fail because the pull request still put output files into the old location, but the executable now places them into a different location. Fix this by moving a file to its now correct location. It here also requires updating the .cc file slightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #1076 and fixes #934 .