Fix base model initialization for depth dependent material model #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdannberg
approved these changes
May 18, 2018
| # Test depth-dependent material model using simple material model as | ||
| # base model with depth-dependence specified by user-provided function | ||
|
|
||
| # A description of convection in a 2d box. See the manual for more information. |
There was a problem hiding this comment.
It looks like this is copied from somewhere. Can you either remove it, or just say which test/benchmark you copied?
| @@ -0,0 +1,175 @@ | |||
| # Test depth-dependent material model using simple material model as | |||
| # base model with depth-dependence specified by user-provided function | |||
There was a problem hiding this comment.
Can you say that this tests the time dependence of the function in the depth dependent material model?
| # A test using adiabatic conditions and a gravity | ||
| # profile generated by a mineral physics toolkit and read in | ||
| # through an ascii data file. In this example, material properties | ||
| # are based on a Birch-Murnaghan equation of state. |
There was a problem hiding this comment.
Can you update this comment?
|
+1 -- obscure bug not easy to figure out! |
gassmoeller
force-pushed
the
fix_depth_dependent_initialization
branch
from
cf87602
to
d29daa4
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2250. The depth dependent material model did not initialize or update its base model, which is fine for most material models, but not for the ones that require initialization (like ascii reference profile). This is now done correctly, and at the same time allows to prescribe time-dependent viscosity functions.