Fix some typos #2673
Merged
Fix some typos #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, a submodule references a specific commit hash. This means the title of this PR is not quite fitting. |
gassmoeller
force-pushed
the
fix_some_typos
branch
from
113b573
to
d21385c
Compare
|
Ok, I removed the world builder update. Only typos now, and should be ready to merge when the testers are happy. |
tjhei
reviewed
Sep 26, 2018
| "More information on the World Builder can be found at " | ||
| "https://geodynamicworldbuilder.github.io ." | ||
| "https://geodynamicworldbuilder.github.io. " |
There was a problem hiding this comment.
the space after "io" is probably there so that is it not seen as part of the url. How are we handling URLs in parameters, anyway? With or without {url}?
There was a problem hiding this comment.
I do not think there is a policy yet, but including links is reasonable. I have checked that \url works in the pdf, and included it.
freddrichards
pushed a commit
to freddrichards/aspect
that referenced
this pull request
May 20, 2019
Fix some typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for #2574, nothing critical, just things I noticed but did not want to delay the PR further for.
@MFraters: When I updated the world builder submodule git commited the change to the version of the submodule as well. Does that mean we need to manually update the submodule every time we want to have a newer version of the world build? Or the other way around: Does the version of the world build in ASPECT stay the same if we do not update it? I guess this ties into #2613, and we should continue the discussion there at some point in the future, but here I was just curious. I can remove the update to the world builder when that is wanted, but the current version of the world build that is part of ASPECT has some serious bugs (like it returns the composition as a bool instead of a double), so maybe we want to keep the update in this PR?