use http git submodule for WorldBuilder #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The submodule is currently specified to use ssh. When somebody clones aspect with ``git clone --recursive https://github.com/geodynamics/aspect`` it will try to fetch the world builder using ssh (and ask for authentication or fail). Change this. I don't see any disadvantage of doing so.
MFraters
approved these changes
Apr 6, 2019
freddrichards
pushed a commit
to freddrichards/aspect
that referenced
this pull request
May 20, 2019
use http git submodule for WorldBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submodule is currently specified to use ssh. When somebody clones
aspect with
git clone --recursive https://github.com/geodynamics/aspectit will try to fetch the worldbuilder using ssh (and ask for authentication or fail).
Change this.
I don't see any disadvantage of doing so.