Fix cookbook phase for slow testers #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sigh, this has been complicated and annoying. Would it make sense to use ? |
|
Yes, but I first want to see if this actually fixes it. And I agree, this takes much more time and effort than it should. |
|
At least the Github Actions seem to be working fine. |
|
This brought down the time for the cookbook phase from 20 min timeout to 5min50s on the slow testers, so I would call this a success. Could you merge this so I can rebase #3624? |
|
Oh wait, I will adjust the CPU number. |
gassmoeller
force-pushed
the
fix_cookbook_phase
branch
from
c99dbe0
to
5265c45
Compare
why did it fail in the documentation now though? :-/ |
tjhei
approved these changes
Jul 30, 2020
|
The actions passed for the earlier commit before I force-pushed. I suspect #3622 might have broken it? |
|
This is good to go. Please merge (or wait for CIG Jenkins to finish). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cookbook testing phase introduced in #3621 does not finish in time on the slow testers (see some of the other current PRs). Reduce concurrency and increase acceptable runtime.