-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added elastic stress contribution to stress and shear stress vis pp #4001
added elastic stress contribution to stress and shear stress vis pp #4001
Conversation
Following PR #4002 the stress field names needed to add the elastic contribution will have to be changed in stress.cc and shear_stress.cc according to the new naming scheeme from stress_xx to ve_stress_xx etc. |
Thanks updating these plugins. I think it would be good to explicitly talk about this in the documentation. Could you add a line to the documentation in at the bottom of the cc file and the header file stating that the elastic stress is accounted for if present? |
3b316d9
to
bd01f11
Compare
Good point @MFraters, done! |
That should be easy to fix with the following: checkout master, pull from the master from this repository (the default name is origin, so that would be |
bd01f11
to
5ffdb63
Compare
Thanks @MFraters this worked! |
Great :) Can you indent the code? Then we can see the test results. You can do this by using If it gives an error you need to make sure that you have installed the correct version of astyle (you can for example use P.S. could you change |
5ffdb63
to
4d2759b
Compare
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this these files and adding the documentation!
Apparently we don't have any tests which use either of these visualization postprocessors and elasticity. That might be something to add in the future.
While the elastic contribution is added to the principal stress postprocesor, it was not in the stress and shear stress postprocesors.
Before your first pull request:
For all pull requests:
For new features/models or changes of existing features: