Add dealii dev tester #4099
Add dealii dev tester #4099
Conversation
gassmoeller
force-pushed
the
add_dealii_dev_tester
branch
from
ca77d9e
to
bb6c8da
Compare
|
Rebased on #4100. |
gassmoeller
force-pushed
the
add_dealii_dev_tester
branch
from
bb6c8da
to
ae98db0
Compare
gassmoeller
force-pushed
the
add_dealii_dev_tester
branch
from
ae98db0
to
d011622
Compare
|
I rebased on #4100, this should be ready if we agree it is a good idea. |
|
Is it useful to do this on each PR? I think we talked about it to be run on master at regular intervals instead. It is a bit weird that a change of deal.ii master will make the next user PR fail... |
|
I am a bit undecided. Yes it is weird that deal.II dev would make our tester fail, on the other hand it ensures high priority. If we run it daily instead we can actually run the full test suite (without comparing results), but we would still merge PRs that break with deal.II dev. Not sure which (or both) is better, what do you think? |
|
Not sure either. I would say it is more likely to have deal.ii master change, than a user adding something that works with the last release but not with master. |
|
Alright, I will change it to run daily on master. |
|
Whatever breaks with deal.II dev at any given moment will require a fix sooner rather than later anyway. We might as well catch this at the time of proposing a patch, and if necessary spend a few minutes explaining the situation to someone, rather than requiring someone else to go back to fix it. |
|
In other words, I'm for it. |
|
@bangerth: Do you mean you are for a daily run of the full testsuite (would require changes), or a smaller run for every PR that only compiles (the current state of this PR)? I am fine with either or both. |
|
If we have the resources, I'm always for adding things to the CI :-) |
|
In that case this PR is ready for merge (this is the quick 10 min test that aspect compiles with deal.II dev). I agree that it puts more pressure on us to fix problems quickly. Having a daily test that just sends an email, or changes a badge color is not as obvious. If it triggers too often because of unrelated things we can always disable it later. |
|
I'm in favor. Should we merge? |
|
Yes. |
|
I am not convinced that this won't end up confusing PR creators, but we can try... |
|
Looks like we need a bold leader willing to take a stand and press the button, consequences be damned! I will be that person for today! |
|
Was that Gru I saw on your desktop? |
|
I don't know who Gru is, but I had the minion, the superhero, and a bunch of dinos from last year that have kept me company since then :-) |
This adds a github action that compiles ASPECT against the dealii/dealii:master-focal container with every PR. Currently does not run the test suite.
No more PRs that work on the tester but break on deal.II dev 🎉