Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documenation of drucker prager parse_parameters() #4304

Merged
merged 1 commit into from Aug 11, 2021

Conversation

anne-glerum
Copy link
Contributor

Fixes #4273.

Update the documentation of the parse_parameters function now that its implementation has changed.

@gassmoeller For dislocation and diffusion creep, the documentation says it's the number of phase transitions. The way I read the code, it's the number of phases, so I've updated the documentation accordingly. Is this correct?

For all pull requests:

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. I dont know why diffusion and dislocation creep refer to it as the number of transitions, it should be the number of phases (if they use the same parameter).

@gassmoeller gassmoeller merged commit 88d98d9 into geodynamics:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drucker-prager documentation warning
2 participants