Refactor velocity postprocessor output #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tjhei
approved these changes
Sep 6, 2021
| for (std::map<types::boundary_id, double>::const_iterator | ||
| p = global_max_vel.begin(), a = global_min_vel.begin(), rms = global_rms_vel.begin(); | ||
| p != global_max_vel.end() && a != global_min_vel.end() && rms != global_rms_vel.end(); | ||
| ++p, ++a, ++rms, ++index) | ||
| { | ||
| if (this->convert_output_to_years() == true) |
There was a problem hiding this comment.
Do you know what the meaning of p and a is? Can you replace the variable names please?
Yes, that is the risk when fiddling around with one of the oldest postprocessors :-). Let's see what the tester thinks about this new version. |
tjhei
approved these changes
Sep 7, 2021
gassmoeller
deleted the
refactor_velocity_boundary_residual_statistics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors some of our velocity statistics postprocessors to remove code duplication caused by unit conversion between seconds and years. Also assert a special behavior of the boundary_velocity_residual_statistics postprocessor, which looks like it is prepared to work for several boundaries simultaneously, which we did not test so far (currently it is hard-coded to only compute the statistics for the surface boundary).