More GeometryInfo work. #4431
Merged
More GeometryInfo work. #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, uncontroversial doesn't mean that it works apparently. But I can't make sense of the CI error message. Did something just happen to die independent of what my patch contains? |
|
We have one test that occasionally provides different results (simple_shear_output_the_mobility) at the moment. I think #4433 should fix the issue, and the test is completely unrelated to the change in this PR (it uses the box geometry). Could you take a look at #4433 and rebase this PR after the other one has been merged? I am pretty sure that should fix the issue. |
|
Rebased now on top of #4433. |
gassmoeller
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems uncontroversial.
/rebuild