Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilities: move inline funcs down #5113

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Utilities: move inline funcs down #5113

merged 1 commit into from
Apr 5, 2023

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Mar 14, 2023

  • fix typos
  • move inline implementations to the bottom of the file

followup to #5094

@MFraters MFraters mentioned this pull request Mar 22, 2023
Open
MFraters
MFraters approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo fixes. The compiler doens't seem able to find the definitions of compute_sorting_permutation and apply_permutation, but it is able to find the other ones you moved. I don't directly see why that is.

@tjhei
Utilities: move inline funcs down
58633cb 
- fix typos
- move inline implementations to the bottom of the file

followup to geodynamics#5094
@tjhei
Copy link
Member Author

tjhei commented Mar 24, 2023

fixed, sorry.

@tjhei
Copy link
Member Author

tjhei commented Apr 5, 2023

ping!

@gassmoeller
Copy link
Member

The failing test is unrelated.

@gassmoeller gassmoeller merged commit 3b4b80e into geodynamics:main Apr 5, 2023
@tjhei tjhei deleted the random_util_followup branch April 5, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gassmoeller gassmoeller gassmoeller approved these changes

@MFraters MFraters MFraters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjhei @gassmoeller @MFraters