Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added entropy as optional field type #5246

Merged
merged 1 commit into from Jul 10, 2023

Conversation

bobmyhill
Copy link
Member

This PR adds entropy as a new field type.

Copy link
Member

@MFraters MFraters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add it to

prm.declare_entry ("Types of fields", "unspecified",
Patterns::List (Patterns::Selection("chemical composition|stress|strain|grain size|porosity|density|generic|unspecified")),
"A type for each of the compositional fields requested. "
"Each entry of the list must be "
"one of several recognized types: chemical composition, "
"stress, strain, grain size, porosity, general and unspecified. "
"The generic type is intended to be a placeholder type "
"that has no effect on the running of any material model, "
"while the unspecified type is intended to tell ASPECT "
"that the user has not explicitly indicated the type of "
"field (facilitating parameter file checking). "
"If a plugin such as a material model uses these types, "
"the choice of type will affect how that module functions.");
. Otherwise looks good to me.

@MFraters MFraters merged commit 6b8845d into geodynamics:main Jul 10, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants