Require fields of type entropy in entropy assembler and adiabatic con… #5297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Jul 13, 2023
Comment on lines
285
to
286
| assemblers.advection_system[entropy_index].resize(1); | ||
| assemblers.advection_system[entropy_index][0] = std::make_unique<Assemblers::EntropyAdvectionSystem<dim>>(); |
There was a problem hiding this comment.
Suggested change
| assemblers.advection_system[entropy_index].resize(1); | |
| assemblers.advection_system[entropy_index][0] = std::make_unique<Assemblers::EntropyAdvectionSystem<dim>>(); | |
| assemblers.advection_system[entropy_index].clear(); | |
| assemblers.advection_system[entropy_index].emplace_back (std::make_unique<Assemblers::EntropyAdvectionSystem<dim>>()); |
|
I've addressed your one comment (I also changed it for the temperature just above). |
bangerth
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ditions. Rather than asking for the name, the changes in #5246 and #5039 allow us to now check the field type.
I haven't done this in the material model yet since @RanpengLi is changing things in the same file but we should do it there as well.
For all pull requests: