Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove/rework partitioning.py #297

Closed
bobmyhill opened this issue Jun 21, 2017 · 0 comments
Closed

remove/rework partitioning.py #297

bobmyhill opened this issue Jun 21, 2017 · 0 comments

Comments

@bobmyhill
Copy link
Member

This is a really old file which has only a single limited use. It should be replaced with more general functions utilising linear algebra. Specifically, from a bulk composition and list of potential minerals, output:

  • A potential set of mineral compositions and proportions
  • A set of reaction vectors which do not change the bulk composition

We'll eventually need the same functions in burnman.equilibrate anyway.
bobmyhill added a commit that referenced this issue Jun 23, 2017
@bobmyhill
Merge pull request #296 from sannecottaar/geotherms
f7503b7 
I'd still like something to be done with test_partitioning.py, but that can wait for a different PR ... perhaps the one that deals with Issue #297.
@bobmyhill bobmyhill mentioned this issue Mar 24, 2018
Closed
@bobmyhill bobmyhill mentioned this issue Feb 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobmyhill