Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative porosities when using poroelastic material with state variables #658

Closed
danieldouglas92 opened this issue Sep 29, 2023 · 7 comments · Fixed by #666
Closed

Negative porosities when using poroelastic material with state variables #658

danieldouglas92 opened this issue Sep 29, 2023 · 7 comments · Fixed by #666
Assignees
Labels
bug General bug needs: tests Implemented; unit tests and/or full-scale tests needed

Comments

@danieldouglas92
Copy link
Contributor

Describe the bug

When using poroelasticity and state variables, the porosity field can develop

To Reproduce

PETSc branch: knepley/pylith
PyLith fork: https://github.com/baagaard-usgs/pylith.git
PyLith branch: baagaard/example-poroelasticity-statevars

Steps to reproduce the behavior.

pylith step01_elastic_bending.cfg

Expected behavior

The porosity as a physical parameter should not be negative,

Screenshots

image

If applicable, add screenshots to help explain your problem.

Environment

Please provide the following information:

  • OS: Mac Monterey v 12.0.1 M1 Max
  • PyLith version v3

Additional context

Add any other context about the problem here.
step01_elastic_bending.txt
variable_permeability.txt
pylithapp copy.txt
top_boundary.txt

@danieldouglas92 danieldouglas92 added the bug General bug label Sep 29, 2023
@knepley
Copy link
Contributor

knepley commented Sep 29, 2023

Is the porosity a function of other variables? If so, which ones and how are they updated? Pointing me to code is fine.

@baagaard-usgs
Copy link
Contributor

The update of the porosity (plane strain) is in fekernels/IsotropicLinearPoroelasticity.hh.

@danieldouglas92
Copy link
Contributor Author

I'm not 100% sure if this is the place but I see it in IsotropicLinearPoroelasticity.hh at line 2488

@knepley
Copy link
Contributor

knepley commented Sep 29, 2023

We should put in an assert there for negative porosity, or a clamp

@danieldouglas92
Copy link
Contributor Author

The porosity should only be between 0 and 1, so I think a clamp makes sense!

@rwalkerlewis
Copy link
Contributor

rwalkerlewis commented Sep 29, 2023 via email

@baagaard-usgs baagaard-usgs added the needs: tests Implemented; unit tests and/or full-scale tests needed label Sep 29, 2023
@baagaard-usgs baagaard-usgs self-assigned this Sep 29, 2023
@baagaard-usgs
Copy link
Contributor

Fixed in branch example-poroelasticity-statevars in https://github.com/baagaard-usgs/pylith.git.

@baagaard-usgs baagaard-usgs changed the title Negative Porosities when Using Poroelastic Material with State Variables Negative porosities when using poroelastic material with state variables Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug General bug needs: tests Implemented; unit tests and/or full-scale tests needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants