Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce collections for feature store. #686

Merged
merged 4 commits into from
May 28, 2021
Merged

Conversation

simonseyock
Copy link
Member

This PR enforces collections for the feature store. This way the two-binding stays simple and the code can be simplified.

Fixes #653

@coveralls
Copy link

coveralls commented May 21, 2021

Pull Request Test Coverage Report for Build 885454541

  • 22 of 27 (81.48%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 81.056%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/data/store/Features.js 20 25 80.0%
Files with Coverage Reduction New Missed Lines %
src/data/store/WfsFeatures.js 2 69.06%
Totals Coverage Status
Change from base Build 885426217: -0.4%
Covered Lines: 1381
Relevant Lines: 1630

💛 - Coveralls

Copy link
Member

@marcjansen marcjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me.

If possible, start collection upgrade notes / a chnagelog here or elsewhere, so we capture the breaking changes like this one.

Please merge at will.

Copy link
Contributor

@chrismayer chrismayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks really good and simplifies this a lot (did not test in running the code in an application). Thanks for this!

@simonseyock simonseyock merged commit 732ac16 into master May 28, 2021
@simonseyock simonseyock deleted the synchronize-features branch May 28, 2021 13:29
@marcjansen marcjansen mentioned this pull request Aug 28, 2021
5 tasks
marcjansen added a commit to marcjansen/geoext3 that referenced this pull request Aug 28, 2021
marcjansen added a commit that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two-way binding between a layer and store in GeoExt.data.store.Features
4 participants