-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce collections for feature store. #686
Conversation
Pull Request Test Coverage Report for Build 885454541
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me.
If possible, start collection upgrade notes / a chnagelog here or elsewhere, so we capture the breaking changes like this one.
Please merge at will.
b01b072
to
b9ebc8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks really good and simplifies this a lot (did not test in running the code in an application). Thanks for this!
Fix broken examples after #686
This PR enforces collections for the feature store. This way the two-binding stays simple and the code can be simplified.
Fixes #653