New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken examples after #686 #705

Merged

marcjansen merged 1 commit into geoext:master from marcjansen:partly-fix-704

Aug 30, 2021

Member

marcjansen commented Aug 28, 2021

Fixes the following examples:

https://geoext.github.io/geoext/master/examples/filtered-heatmap/filtered-heatmap.html is broken and fails with GeoExt.data.store.Features needs to be configured with a feature collection or with a layer with a source with a feature collection, most probably broken since Enforce collections for feature store. #686
https://geoext.github.io/geoext/master/examples/features/grid.html has the same issue
https://geoext.github.io/geoext/master/examples/features/grid-filter.html has the same issue

See #704


          Fix broken examples after geoext#686

120383f

marcjansen mentioned this pull request

Some broken examples #704

Open

5 tasks

simonseyock approved these changes

View reviewed changes

Member

simonseyock left a comment

Good catches! Looks very nice, just one minor remark.

Member

simonseyock commented Aug 30, 2021

Please ignore my remark, I read that the wrong way. Everything looks fine!

Member Author

marcjansen commented Aug 30, 2021

Thanks for the review.

marcjansen merged commit 9956ce6 into geoext:master

marcjansen deleted the partly-fix-704 branch

August 30, 2021 07:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment