Version 2.5.0.2 Seach Engine Friendly URLs Not Enabling

[diatonic]

Reporting About the Latest Version? Yes - Tested on 2.6 as well with same result

Searched Issue Reports for Bug? Yes

Reviewed the Good To Know Issue Reports? Yes

BCOE&M Info
Version: v2.5.0.2
Installation URL: https://idbeer.org
Hosted Installation? No

Describe the Bug
Enabling Search Engine Friendly URLs preference does not affect navigation links, but SEF links are working

To Reproduce
Steps to reproduce the behavior:

1. Go to Website Preferences
2. Enable Search Engine Friendly URLs
3. Save Changes
4. Navigation links are not SEF

Expected Behavior
Search Engine Friendly Links in navigation

Screenshots

Server Environment

• PHP Version: 8.2.5
• MySQL Version: 10.5.16-MariaDB
• Other Info: Apache/2.4.53 (AlmaLinux)

Local Environment

• OS: Windows 11
• Browser: Edge & Firefox
• Browser Version: Latest

Additional Context
SEF URLs work on the server, but navigation links continue to not use them

[diatonic]

Perhaps related to using an unsupported version of php. Saw that the installation instructions state not to use a version newer than 7.3.X.

[geoffhumphrey]

Hi @diatonic - thanks for reporting. If you change lines 164-178 (2.6.0 release) of /lib/common.lib.php to the following, the issue will be resolved:

if ($_SESSION['prefsSEF'] == 'Y') {
	$url = $base_url."";
	if ($section != "default") $url .= $section."/";
	if ($go != "default") $url .= $go."/";
	if ($action != "default") $url .= $action."/";
	if ($id != "default") $url .= $id."/";
	return rtrim($url,"/");
}
	
else {
	$url = $base_url."index.php?section=".$section;
	if ($go != "default") $url .= "&go=".$go;
	if ($action != "default") $url .= "&action=".$action;
	if ($id != "default") $url .= "&id=".$id;
	return $url;
}

Or, simply download and install the entire /lib/common.lib.php file from the latest commit to your installation.