Make MapBox interface compatible with MultiGeocoder #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ class MapboxGeocoder < Geocoder | |||
| private | |||
|
|
|||
| # Template method which does the reverse-geocode lookup. | |||
| def self.do_reverse_geocode(latlng) | |||
| def self.do_reverse_geocode(latlng, options = {}) | |||
There was a problem hiding this comment.
Unused method argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used.
1 similar comment
|
Maintainers: let me know if I should act on any of this auto-feedback 😁 |
mnoack
pushed a commit
that referenced
this pull request
Feb 19, 2015
Make MapBox interface compatible with MultiGeocoder
|
Thanks @yitznewton The auto feedback is usually fairly good to act on (apart from line-too-long is sometimes overzealous). This PR seems fairly good, safe and improves coverage so I'll just merge it. I'm not sure when I should release a gem. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using MapBox with the
MultiGeocoder, and Geokit's MapBox geocoder did not take the secondoptionsargument used by multi, resulting in errors likeThis PR fixes that by adding the argument to the appropriate methods, and ignoring it.
The tests simply confirm that no error is raised when geocoding with MapBox.