Fix removing temp-layer if layer is removed while rotation (#998) (pa…

…tch)

* Fix removing temp-layer if layer is removed while rotation

* Replace with disableRotate

* Update src/js/Mixins/Rotating.js

* Update src/js/Mixins/Rotating.js

* Update src/js/Mixins/Rotating.js

Co-authored-by: Sumit Kumar <sk@outlook.com>

cypress/integration/rotation.spec.js

@@ -191,4 +191,20 @@ describe('Rotation', () => {
       expect(Math.ceil(layer.pm.getAngle())).to.eq(64);
     });
   });
+
+  it('removes hidden rotatePoly if layer is removed', () => {
+    cy.toolbarButton('rectangle')
+      .click()
+      .closest('.button-container')
+      .should('have.class', 'active');
+    cy.get(mapSelector).click(200, 200).click(600, 350);
+
+    cy.window().then(({ map }) => {
+      const layer = map.pm.getGeomanDrawLayers()[0];
+      layer.pm.enableRotate();
+      const rotatePoly = layer.pm._rotatePoly;
+      layer.remove();
+      expect(!!rotatePoly._map).to.eq(false);
+    });
+  });
 });

src/js/Mixins/Rotating.js

@@ -168,6 +168,8 @@ const RotateMixin = {
 
     this._rotateEnabled = true;
 
+    this._layer.on('remove', this.disableRotate, this);
+
     this._fireRotationEnable(this._layer);
     // we need to use this._layer._map because this._map can be undefined if layer was never enabled for editing before
     this._fireRotationEnable(this._layer._map);
@@ -181,6 +183,8 @@ const RotateMixin = {
       this._rotatePoly = undefined;
       this._rotateOrgLatLng = undefined;
 
+      this._layer.off('remove', this.disableRotate, this);
+
       this._rotateEnabled = false;
 
       this._fireRotationDisable(this._layer);