Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in console when remove last vertex #392

Closed
ashmigelski opened this issue Jan 24, 2019 · 5 comments
Closed

Error in console when remove last vertex #392

ashmigelski opened this issue Jan 24, 2019 · 5 comments
Labels
bug

Comments

@ashmigelski
Copy link

Found error in console after click Remove last vertex.

Steps to reproduce:

  • start draw polygon
  • click on map to add first point
  • click on Remove last vertex in toolbar
  • check console, error will there

peek 2019-01-24 12-26

PS leaflet.pm works very well for me! Thanks
codeofsumit added a commit that referenced this issue Jan 24, 2019
@codeofsumit
removeLastVertex now stops after disabling drawing. Fixes #392
8a1c0b7
@codeofsumit
Copy link
Contributor

Thanks for reporting it. Please try version 2.0.1 - should be fixed 🤞

@ashmigelski
Copy link
Author

Updated to version 2.0.1
removeLastVertex fixed!

But I found same issue with 'Finish' button
peek 2019-01-25 13-42

@codeofsumit
Copy link
Contributor

hm I don't get that error @ashmigelski 🤔
The shape is not finished (which is correct) but for me it doesn't throw an error.
Do you also see that on the demo page?

codeofsumit added a commit that referenced this issue Jan 25, 2019
@codeofsumit
Fix finish action as mentioned in #392 (patch)
f8d77b5
@codeofsumit
Copy link
Contributor

@ashmigelski nevermind, I found it. Fixed. Will be in the next release, thanks for reporting 👍

@ashmigelski
Copy link
Author

Nice to hear
I leave screenshot about my error here, it's about allowSelfIntersection: false
error

Thanks again!

hefler added a commit to zoopit/leaflet-geoman that referenced this issue Jan 30, 2019
@hefler
Merge branch 'develop'
be70c9e 
* develop:
  2.0.2
  Fix various Intersection Problems (geoman-io#397) Circle Helpers are now properly ignored (patch)
  Fix circle resizing when center is moved. Fixes geoman-io#357. (patch)
  Fix finish action as mentioned in geoman-io#392 (patch)
  2.0.1
  unified formatting with prettier (patch)
  removeLastVertex now stops after drawing is disabled. Fixes geoman-io#392 (patch)
  Active global modes are now re-applied to new layers. Fixes geoman-io#393. (geoman-io#394) (patch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeofsumit @ashmigelski