Improvement disable control button when change state we do not redraw panel #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Branch
… the control panel
|
Please review my PR @Falke-Design |
Falke-Design
requested changes
Feb 18, 2022
|
For example, I can give an example of code from the leaflet library, they have buttons for zooming the map and don't render after disable. The redraw render is complex for the browser. |
codeofsumit
approved these changes
Apr 6, 2022
Falke-Design
approved these changes
Apr 7, 2022
BaharWeb
pushed a commit
to BaharWeb/leaflet-geoman
that referenced
this pull request
May 13, 2022
… panel (geoman-io#1094) (patch) * Improvement disable control button when change state we do not redraw the control panel * Fixed test * Fixed test * Fix removing event listener Co-authored-by: Sumit Kumar <sk@outlook.com> Co-authored-by: Florian Bischof <design.falke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When studying the code, it was found that the optimal movement, which causes a complete redrawing of the control panel, when changes disable state.
This PR makes the following changes: