Additional Custom Control Methods #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds `buttonExists(name: string)` to get the status of a button - adds `getCustomButtons()` that returns an object of all of the custom controls - ts definitions
Falke-Design
requested changes
Feb 19, 2023
src/js/Toolbar/L.PM.Toolbar.js
Outdated
Comment on lines
569
to
575
| getCustomControls() { | ||
| return Object.fromEntries( | ||
| Object.entries(this.getButtons()).filter( | ||
| ([, v]) => v._button.tool === 'custom' | ||
| ) | ||
| ); | ||
| }, |
There was a problem hiding this comment.
Let us make this more general:
Suggested change
| getCustomControls() { | |
| return Object.fromEntries( | |
| Object.entries(this.getButtons()).filter( | |
| ([, v]) => v._button.tool === 'custom' | |
| ) | |
| ); | |
| }, | |
| getButtonsInBlock(name) { | |
| const buttonsInBlock = {}; | |
| if(name){ | |
| for(const buttonName in map.pm.Toolbar.getButtons()){ | |
| const button = map.pm.Toolbar.getButtons()[buttonName]; | |
| // draw controls doesn't have a block | |
| if(button._button.tool === name || (name === 'draw' && !button._button.tool)){ | |
| buttonsInBlock[buttonName] = button; | |
| } | |
| } | |
| } | |
| return buttonsInBlock; | |
| } |
Falke-Design
requested changes
Feb 19, 2023
|
Apologies for the delay @Falke-Design, finally came back to this and fixed suggestions. |
Falke-Design
requested changes
Feb 27, 2024
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation is for React reasons, since an error is thrown if a button has already been mounted (when the component rerenders...), these checks are helpful to avoid issues.
buttonExists(name: string)to get the status of a buttongetCustomButtons()that returns an object of all of the custom controls