Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selfIntersection check on cut #367

Merged
merged 2 commits into from Jan 8, 2019
Merged

Fix selfIntersection check on cut #367

merged 2 commits into from Jan 8, 2019

Conversation

bugleev
Copy link
Contributor

@bugleev bugleev commented Dec 12, 2018

Found a bug, steps to reproduce:

  1. Draw a polygon
  2. Start drawing a cutting shape in it with allowSelfIntersection = false

selfintersection-false

  1. Click on first vortex (as the cursor snaps to it)
  2. Shape is cut

selfintersection-done

bugleev and others added 2 commits December 12, 2018 12:38
Fixing a bug, where you can click on first vortex (with intersection being highlighted) and finish the cut shape even if allowSelfIntersection is false.
@codeofsumit codeofsumit merged commit 8541cfc into geoman-io:develop Jan 8, 2019
@codeofsumit
Copy link
Contributor

Thank you for your work on this, @bugleev 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants