Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar block position #626

Merged
merged 4 commits into from Jul 17, 2020
Merged

Toolbar block position #626

merged 4 commits into from Jul 17, 2020

Conversation

Falke-Design
Copy link
Collaborator

Add function map.pm.Toolbar.setBlockPosition(block,position) to set position of each block

grafik

codeofsumit
codeofsumit suggested changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@codeofsumit codeofsumit left a comment •
edited by Falke-Design

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's amazing! Some minor things but then we can merge it.

  • See line comments
  • A test 😁

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/js/Toolbar/L.PM.Toolbar.js Outdated Show resolved Hide resolved
codeofsumit
codeofsumit approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@codeofsumit codeofsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeeet

@codeofsumit codeofsumit merged commit b2a4d3e into geoman-io:develop Jul 17, 2020
@Falke-Design Falke-Design deleted the toolbar_position branch November 11, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeofsumit codeofsumit codeofsumit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Falke-Design @codeofsumit