Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactor geometry #45

Merged
merged 18 commits into from
Dec 8, 2016
Merged

[WIP] Refactor geometry #45

merged 18 commits into from
Dec 8, 2016

Conversation

desyncr
Copy link
Member

@desyncr desyncr commented Dec 2, 2016 •
edited

This PR is meant to keep track of changes and contribute towards geometry's v2.

TODO

  • Update README.md
  • Enforce naming convention

@desyncr
Initial plugin architecture set up
9a0fd4b
@desyncr
Enhance code structure. Better plugin code separation.
80f7b2a
@desyncr
Separate async mode from git plugin. Fixed exec_time plugin.
5558ec1
@desyncr
Moved grep function to lib
927cc12
@desyncr
Add missing zsh/datetime
543140b
@desyncr
Fix exec_time plugin issue with multiple enter key pressed
8228367
@desyncr
Refactor async library and fix coding style
4215693
@desyncr
Make plugins self-register. Added geometry_plugin_list function.
83b6ac4
@desyncr
Add plugin separator configuration
d17a392
@desyncr
Avoid multiple plugin registration
ceb9447
@desyncr
Refactor time library
9c662c4
@desyncr
Add unregister/shutdown methods
5c424fc
@desyncr
Moved time lib configuration variables
1bb1906
@desyncr
Fix error index with time lib
d170eb1
@desyncr
Fix time short/long format functions
11b9352
@desyncr
Fix plugin registration duplicate check
cc591ee
@desyncr
Add function alias for prompt_geometry_colorize as -g-color
b63ff42
@desyncr desyncr requested a review from frm December 7, 2016 22:39
@desyncr
Copy link
Member Author

desyncr commented Dec 7, 2016

I have been using v2 for two weeks now. One thing I saw:

  • On huge repositories with async the user may face a git .lock message on some operations

In general it does work as expected with custom plugins.

@frmendes Will need further feedback to move forward.

frm
frm approved these changes Dec 8, 2016
View reviewed changes
Copy link
Member

@frm frm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and start working on adding what's missing and improving it. No need to squash everything, to keep the changelog.

@frm frm mentioned this pull request Dec 8, 2016
Closed
@desyncr desyncr merged commit 02344d2 into master Dec 8, 2016
@desyncr
Copy link
Member Author

desyncr commented Dec 8, 2016

Done! 👍

@desyncr desyncr mentioned this pull request Dec 9, 2016
Closed
@frm frm deleted the v2 branch December 11, 2016 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frm frm frm approved these changes

Assignees

@desyncr desyncr

@frm frm

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@desyncr @frm