Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop-types, prop-type definitions #92

Open
CaitW opened this issue May 28, 2017 · 1 comment
Open

Add prop-types, prop-type definitions #92

CaitW opened this issue May 28, 2017 · 1 comment

Comments

@CaitW
Copy link
Member

CaitW commented May 28, 2017

prop-types

  • We do not currently have a method for type-checking component props.
  • Prop-types would be easy to add on a component-by-component basis as development continues
  • We can omit the prop-types library from the production build, meaning little effective file-size increase
@theduckylittle
Copy link
Member

I'm cool with keeping this alive a a potential enhancement and am generally a fan of type checking but in terms of dev effort, writing more tests will likely bear more fruit in the near term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants