Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure Tool Enhancements #837

Merged

Conversation

theduckylittle
Copy link
Member

@theduckylittle theduckylittle commented May 30, 2023

The goal of this PR is to provide:

  • Measure features that are preserved on the map.
  • Measure features with a new, more complex styling.
  • [ ] Hover interactions between the features on the map and the features in the measure list. Went with better cartography instead of the hover interaction.

@chughes-lincoln
Copy link
Contributor

This looks great so far!

I noticed a few things:

  • Measure points no longer show up on the map - this might be included in your new complex styling
  • Measure lines - subsequent measurements recalculate the final segment of previous measurements
  • Draw Polygon throws a console error - polyline attribute points: Expected number - I'm not sure what impact this has other than
  • I'm not sure how useful the incremental area calculation is. I could see why people might want it, but it might be confusing for the average user. I think having results for each individual line segment is intuitive (as well as the sum), but having the history of all potential versions of a polygon isn't as intuitive. I feel like when someone's measuring lines, they want the distances and bearings of each line segment, but when people are measuring polygons, they're goal is measuring the final polygon. I do really like having a picture of the polygon in the measure results.
  • If I start a measurement, and then close the measure tool before finishing the measurement, the result will remain in the results tab and can't be cleared (unless I start another tool or start another measurement)

@theduckylittle theduckylittle force-pushed the feature/keep-measure-tool-features branch from 1470972 to 3016b55 Compare June 9, 2023 19:48
@klassenjs klassenjs added this to the 3.12.0 milestone Jun 16, 2023
- Moved math out of the component and into math
   functions.
- Measure tool help is now in a proper info box.
- Line length totals will now prevent having issues
   with small aggregations.
- Re-used gm-grid for the segment read out instead
   of the uglier vanilla table.
- Add legends to all measure types

Rework of how measure features are stored.
- Measure features now have their own source-type.
- Measure features will now have their own custom internal
  style render.

Add Table view for points
@theduckylittle theduckylittle force-pushed the feature/keep-measure-tool-features branch from 223a848 to 627e4bf Compare June 17, 2023 11:27
@klassenjs klassenjs merged commit 0ed1871 into geomoose:main Jul 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants