add extrinsic to spherical and its tangent #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1195 +/- ##
==========================================
- Coverage 94.32% 94.31% -0.00%
==========================================
Files 90 90
Lines 9072 9102 +30
==========================================
+ Hits 8556 8584 +28
- Misses 516 518 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ninamiolane
approved these changes
Dec 2, 2021
| @@ -173,6 +174,71 @@ def tangent_spherical_to_extrinsic( | |||
|
|
|||
| return tangent_vec_extrinsic | |||
|
|
|||
| def extrinsic_to_spherical(self, point_extrinsic): | |||
There was a problem hiding this comment.
Add a docstring?
It would be nice to add there which point is considered the origin of the spherical coordinates.
There was a problem hiding this comment.
Sorry forgot! Weird that DeepSource didn't detect it though
There was a problem hiding this comment.
And now adding docstrings fails codecov?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functions to work with spherical coordinates