Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 New tests #1493

Merged
merged 22 commits into from Apr 15, 2022
Merged

11 New tests #1493

merged 22 commits into from Apr 15, 2022

Conversation

SaitejaUtpala
Copy link
Collaborator

New tests for

Product Manifold :

  • test_product_dimension_is_sum_of_dimensions

Riemannian Metric

  • test_triangule_inequality_of_dist

Product Riemannian metric

  • test_innerproduct_is_sum_of_innerproducts
  • test_metric_matrix_is_block_diagonal

Quotient Manifold

  • test_dist_is_smaller_than_bundle_dist
  • test_log_is_horizontal

Pullback Metric

  • test_innerproduct_is_embedding_innerproduct

Invariant Metric

  • test_exp_at_identity_of_lie_algebra_belongs
  • test_log_belongs_to_lie_algebra
  • test_exp_after_log_at_identity
  • test_log_after_exp_at_identity

@SaitejaUtpala SaitejaUtpala marked this pull request as draft April 13, 2022 00:41
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1493 (3c7dc87) into master (bc82fbf) will increase coverage by 0.38%.
The diff coverage is 66.67%.

@@            Coverage Diff             @@
##           master    #1493      +/-   ##
==========================================
+ Coverage   92.47%   92.84%   +0.38%     
==========================================
  Files          95      100       +5     
  Lines       10136    10400     +264     
==========================================
+ Hits         9372     9655     +283     
+ Misses        764      745      -19     
Flag Coverage Δ
autograd 92.41% <ø> (?)
numpy 89.95% <ø> (+0.05%) ⬆️
pytorch 84.12% <100.00%> (ø)
tensorflow 79.73% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/_backend/__init__.py 84.13% <ø> (+1.59%) ⬆️
geomstats/_backend/autograd/__init__.py 98.50% <ø> (ø)
geomstats/_backend/numpy/__init__.py 97.75% <ø> (ø)
geomstats/_backend/tensorflow/__init__.py 93.61% <50.00%> (-0.20%) ⬇️
geomstats/_backend/pytorch/__init__.py 94.64% <100.00%> (ø)
geomstats/_backend/autograd/autodiff.py 97.73% <0.00%> (ø)
geomstats/_backend/autograd/random.py 100.00% <0.00%> (ø)
geomstats/_backend/autograd/linalg.py 97.27% <0.00%> (ø)
geomstats/_backend/autograd/common.py 88.89% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc82fbf...3c7dc87. Read the comment docs.

@SaitejaUtpala SaitejaUtpala marked this pull request as ready for review April 15, 2022 00:12
Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!! Thank you so much.

@ninamiolane ninamiolane merged commit 515f4b2 into geomstats:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants