Fix and simplify pytorch backend: array, einsum, from_numpy #1550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR acts specially in
array
fortorch
backend. It avoids unnecessary conversions tonumpy
.Additionally,
dtype
has been added tofrom_numpy
tocast
when required. It needs to be extended to the other backends for compatibility, but it will play a role whenscipy
is used withtorch
ortensorflow
(to ensure precision is kept).einsum
is also simplified. @ninamiolane the tests are not failing with this simplification, but I'm not sure if I'm missing something (I was not able to understand whyeinsum
had such a complex wrapper). If you have an example that justifies the wrapper, please let me know so I revert the changes there.It closes #1537 and starts paving the path to better performance in GPU.