add geodesic to pullbackdiffeometric #1877
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1877 +/- ##
==========================================
+ Coverage 82.59% 90.72% +8.13%
==========================================
Files 136 140 +4
Lines 13577 13071 -506
==========================================
+ Hits 11213 11857 +644
+ Misses 2364 1214 -1150
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 66 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| Parameters | ||
| ---------- | ||
| point_a : array-like, shape=[..., *shape] |
There was a problem hiding this comment.
Correct the names of parameters
There was a problem hiding this comment.
point_a --> initial_point, etc
| Returns | ||
| ------- | ||
| geodesic : callable | ||
| Geodesic between point_a and point_b. |
There was a problem hiding this comment.
Idem: it's either between initial point and end point, or with initial point and initial tangent vec.
| image_point_a, image_point_b, image_initial_tangent_vec | ||
| ) | ||
|
|
||
| def geod_function(t): |
There was a problem hiding this comment.
rename to path for consistency with the code base.
|
|
||
| Parameters | ||
| ---------- | ||
| point_a : array-like, shape=[..., *shape] |
There was a problem hiding this comment.
point_a --> initial_point, etc
| geodesic : callable | ||
| Geodesic between point_a and point_b. | ||
| """ | ||
| image_point_a = self.diffeomorphism(initial_point) |
There was a problem hiding this comment.
fix variable names for consistency.
for example: image_point_a --> image_initial_point
tests/geometry_test_cases.py
Outdated
| @@ -1696,6 +1697,41 @@ def test_matrix_innerproduct_and_embedded_innerproduct_coincide( | |||
| """ | |||
| # Not yet implemented due to need for local basis implementation | |||
|
|
|||
| def test_dist_vectorization(self, space, n_samples): | |||
There was a problem hiding this comment.
As discussed, these tests are not needed as long as you make PullbackDiffeoMetricTestCase inherit from RiemannianMetricTestCase.
--> Do this and let's see what happens, typically which tests we might need to skip?
Checklist
Description
Issue
Additional context