Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product manifold #109

Merged
merged 56 commits into from
Oct 30, 2019
Merged

Product manifold #109

merged 56 commits into from
Oct 30, 2019

Conversation

ferrine
Copy link
Member

@ferrine ferrine commented Sep 7, 2019

Adding Product Manifold there

@ferrine
draft product manifold class
59351ad
@ferrine
add initial progress on some methods
ee6904a
@ferrine
test slicing
5442b44
@ferrine
add projections
51392a1
@ferrine
draft other methods
0f6f0e2
@ferrine
add tests and fix broadcasting bugs
75aca85
@ferrine
add typehints and make sure there are no more broadcasting problems
7c96bb1
@ferrine
fix lint issue
33e08d2
@ferrine
fix lint issues
cbedb38
@ferrine
fix dist
2751bcf
@ferrine
add scaling utils
0f5367c
@ferrine
fix typo
c1e37bd
@ferrine
fix inner product result
717f5f1
@ferrine
add scalings for poincare
2779b16
@ferrine
scaling rescaling test
722d08a
@ferrine
fix dir method
89fc5b1
@ferrine
empty tensor fix
0ac1a2d
@ferrine
add a bit more tests for product manifold
5de3fcf
@ferrine
fix typo
4a82484
@ferrine
some nitpicka
cbae619
@ferrine
add random methods and device/dtype consistency when __init__
65cdcaf
@ferrine
rest random
29891da
@ferrine
remove annotation
706bd6b
@ferrine
fix lint errors
2c7a426
@ferrine
dist test
4756193
@ferrine
make scaled implementation much cleaner
1d9fe75
@ferrine
add comments
dae235a
@ferrine
fix docstring
0bdd722
@ferrine
add restricted methods
8977282
@ferrine
black
8ecf871
@ferrine ferrine requested a review from rrkarim October 16, 2019 10:07
@ferrine
Copy link
Member Author

ferrine commented Oct 16, 2019

@rrkarim you are welcome to review the PR. If anything is not clear enough, I will elaborate on docs more

rrkarim
rrkarim reviewed Oct 18, 2019
View reviewed changes
Copy link
Member

@rrkarim rrkarim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not register bound methods in scaled manifold for methods like geodesic. So something like this shouldn't work:

ball = geoopt.PoincareBallExact()
sball = geoopt.Scaled(ball, 2)
rsball = geoopt.Scaled(sball, 0.5)
rsball.geodesic

rrkarim
rrkarim reviewed Oct 30, 2019
View reviewed changes
Copy link
Member

@rrkarim rrkarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked tests yet, can you please fix please fix travis fails and I will check the tests tomorrow, other than that I guess we can finally merge it.

@ferrine
Copy link
Member Author

ferrine commented Oct 30, 2019

@rrkarim I've fixed tests, they were related to black updates

@ferrine ferrine merged commit 1cefe59 into master Oct 30, 2019
@ferrine
Copy link
Member Author

ferrine commented Oct 30, 2019

Thanks!

@ferrine ferrine deleted the product-manifold branch October 30, 2019 13:54
andbloch pushed a commit to andbloch/geoopt that referenced this pull request Dec 29, 2019
@ferrine
Product manifold (geoopt#109)
d22d8d3 
* draft product manifold class

* add initial progress on some methods

* test slicing

* add projections

* draft other methods

* add tests and fix broadcasting bugs

* add typehints and make sure there are no more broadcasting problems

* fix lint issue

* fix lint issues

* fix dist

* add scaling utils

* fix typo

* fix inner product result

* add scalings for poincare

* scaling rescaling test

* fix dir method

* empty tensor fix

* add a bit more tests for product manifold

* fix typo

* some nitpicka

* add random methods and device/dtype consistency when __init__

* rest random

* remove annotation

* fix lint errors

* dist test

* make scaled implementation much cleaner

* add comments

* fix docstring

* add restricted methods

* black

* better name

* fix logmap

* fix logmap

* fix logmap

* add component inner method

* change doc

* fix doc

* add origin

* update changelog

* try o avoid warnings in multigpu env with origin

* add more docs for Scaling Info

* add docs

* fix doc

* method directive is not valif

* origin docs

* fix lineskip

* update readme

* fix attributes

* improve component inner for euclidean manifold

* fix broadcasting

* fix typo

* fix signature

* black

* update black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrkarim rrkarim rrkarim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferrine @rrkarim