BUG: pass list-like colors to Multi- geometry

[martinfleis]

As reported earlier, passing a list-like of colors to gdf.plot() will not match rows if there are multipart geometries. That should be fixed now.

Fixes #1075, fixes #730

[codecov]

Codecov Report

Merging #1119 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1119      +/-   ##
==========================================
- Coverage   89.92%   89.82%   -0.11%     
==========================================
  Files          20       20              
  Lines        1935     1965      +30     
==========================================
+ Hits         1740     1765      +25     
- Misses        195      200       +5

Impacted Files	Coverage Δ
geopandas/plotting.py	93.17% <100%> (-0.08%)	⬇️
geopandas/geoseries.py	94.01% <0%> (-2.24%)	⬇️
geopandas/tools/sjoin.py	97.36% <0%> (+0.44%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0556a...fc97251. Read the comment docs.

[BCamina]

As reported earlier, passing a list-like of colors to gdf.plot() will not match rows if there are multipart geometries. That should be fixed now.

Fixes #1075, fixes #730

I've replace the changed files (plotting.py and test_plotting.py) in the geopandas directory and it's still not working for me, I'm experiencing the same bug as before.

I'm currently using geopandas 0.5.1 with Anaconda and Python 3.7

[martinfleis]

@BCamina can you try installing the whole branch using pip install git+git://github.com/martinfleis/geopandas.git@multipolycolor? Alternatively, can you provide reproducible example? Thanks

[BCamina]

@BCamina can you try installing the whole branch using pip install git+git://github.com/martinfleis/geopandas.git@multipolycolor? Alternatively, can you provide reproducible example? Thanks

I tried installing the whole branch using pip install and it worked!
Thank you very much, I spent a whole weekend trying to make it work.

[jorisvandenbossche]

Thanks for fixing this! Looks good, I only have a remark on trying to reduce the calls to _flatten_multi_geoms

[martinfleis]

Okay, I have also covered everything marked by codecov by additional tests. Should be ready to be merged once green.

[martinfleis]

Okay, seems to be ready now.

[jorisvandenbossche]

@martinfleis Thanks! (and especially for your patience with my reviews!)