BUG: Passing array of RGBA tuples to color parameter in .plot() throws error #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1211 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 21 21
Lines 2063 2063
=======================================
Hits 1858 1858
Misses 205 205
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
Nov 18, 2019
jorisvandenbossche
pushed a commit
to jorisvandenbossche/geopandas
that referenced
this pull request
Nov 18, 2019
…s error (geopandas#1211) (cherry picked from commit 92b7aed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing array of tuples (aka list of lists),
np.takein plotting flattens the array causing the error, reported in pysal/splot#83. I thought that it is the same bug as #1178 but this one was slightly different. Both caused by changes in #1119 though.It should be fixed now, including tests.
(there is so many options how to pass colors...)