separate spatial_index function #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"millions_to_hundreds" sjoint, where we split data into chunks and don't want to generate a rtree.Index for each chunk once again
|
maybe it is better to pass index as **kvargs? |
jorisvandenbossche
requested changes
Sep 15, 2016
| @@ -24,9 +45,9 @@ def sjoin(left_df, right_df, how='inner', op='intersects', | |||
| Suffix to apply to overlapping column names (left GeoDataFrame). | |||
| rsuffix : string, default 'right' | |||
| Suffix to apply to overlapping column names (right GeoDataFrame). | |||
| tree_idx : rtree.index for right GeoDataFrame, if None, will be created. | |||
There was a problem hiding this comment.
Can you put the explanation on a next line (see how it is done for the other kwargs). Typically it should have the form of (following the numpy docstring standard)
kwarg : type
Explanation
|
Thanks! I will try to think over a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separate spatial_index function might be of use for "millions_to_hundreds" sjoint, where we split data into chunks and don't want to generate a rtree.Index for each chunk once again