Manage copyright from Mapbox layer #418
Conversation
|
Deploy preview for react-spatial ready! Built with commit ee01f35 |
src/layers/MapboxLayer.js
Outdated
| ); | ||
| } | ||
| }); | ||
| return [...new Set(copyrights.filter(copyright => !!copyright))].join(', '); |
There was a problem hiding this comment.
[..new Set()] is the shorter version
There was a problem hiding this comment.
I just tested it in the console it works : [...new Set(['lala', 'lala'])] => ['lala'']
There was a problem hiding this comment.
@oterral But [...new Set()] is compiled to [].concat[new Set()]. And this returns [object Set].
There was a problem hiding this comment.
thx for the explanation. I fix.
| // Trick from Mapbox AttributionControl to know if the source is used. | ||
| const { sourceCaches } = mbMap.style; | ||
| Object.entries(sourceCaches).forEach(([, sourceCache]) => { | ||
| if (sourceCache.used) { |
There was a problem hiding this comment.
In this example, sourceCache.used is false. Is this intended?
There was a problem hiding this comment.
We display the source's copyright only if the source is used by the style.
oterral
force-pushed
the
olivier/copyright
branch
from
c7a78ed
to
8dd6476
Compare
|
@oterral I merged master into branch and successfully tested on Plan-Editor and and Trafimage-Maps. I would say LGTM |
No description provided.