New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support WaterML 2.0 #131
Comments
Hi, Note that the example request given returns data according to the INSPIRE atmospheric features schema. Only part of this response is WaterML (the om:result uses the WaterML Timeseries type). Cheers, From: Rich Signell [mailto:notifications@github.com] Excerpted from the Ulmo package issue by @jirikadlec2https://github.com/jirikadlec2 "It would be nice to support WaterML 2.0 in ulmo. WaterML 2 is a xml format for hydrologic data and it is an official standard of the OGC: I think it's OK if only the getValues() method with an url parameter is supported. An example WaterML 2.0 request is here: (this is a time-series of air temperature at a station in Finland) — |
FYI @allixender may have comments here / might be working on something. |
Hi all, well, yes I was looking into that. but I got side tracked. I might not Alex Am 19/03/2014 1:27 p.m., schrieb Tom Kralidis:
|
Hi guys, I’d been thinking about WaterML2.0 support for a while, and I had a chat with Dom about it (we are now colleagues since his move down under). He gave me a few pointers on OWSLib background, so this prompted me to take a start. Here is some of the stuff I’ve got working (https://github.com/peterataylor/OWSLib):
There was a small fix required to get the get_observation call to work in the existing sos200.py file (peterataylor@909a1c2). Not sure if this was a service implementation quirk; needs testing on other SOS 2.0 implementations. Further things to look at:
Let me know if any comments. Cheers, |
@peterataylor thanks, impressive work here! I wonder whether we should move the waterml2 things in https://github.com/peterataylor/OWSLib/blob/master/owslib/swe/observation/observation.py to https://github.com/geopython/OWSLib/tree/master/owslib/waterml ? Having said this, would like to hear others' comments. |
Thanks Tom. Yes agree with your comment, and I had considered the waterml package. One thing we need to look at is the various parts of these packages (I was alluding to this in the second point above). The current waterml package is actually a combination of WaterML1.0/1.1 and the WaterOneFlow web service. The observation package I've added has these parts:
These could be split accordingly. Where you might have: Response handler moves into SOS200.py, which would use types from both O&M.py (or something similar) and waterml2.py. That way we can add further types for WaterML2.0, O&M, as well as handling other responses from SOS2.0, e.g. GetFeatureOfInterest. This would then allow the WaterML2.0 and O&M packages to be used with other services, in the same way there is a SWE common package (common.py). E.g. if you need to parse a WFS that returns O&M and/or WaterML2.0. I'll have a look, but also happy to take on any suggestions.. |
Hi Tom, I've refactored the packages to better suit their scope and improves the modularity a little. Here's a short summary:
The main test I've added shows basic usage. |
cc @kwilcox @peterataylor nice work here on the restructuring, makes sense. Any chance you can link up the tests to the docs (or augment the docs directly)? Please submit a PR when this is good to go. |
Hi, has @peterataylor 's work been integrated? |
Hi @mullenkamp - yes it got merged in a while back by @kwilcox, see c73c06e. |
Thanks. I was only asking because this issue is still opened, but (as you said) it looked like it got implemented. |
If I understand correctly this issue is closed by PR #241 since version 0.12.0. I close it now. |
Excerpted from the Ulmo package issue by @jirikadlec2
https://github.com/twdb/ulmo/issues/77,
but would be great if supported by OWSLib:
"It would be nice to support WaterML 2.0 in ulmo. WaterML 2 is a xml format for hydrologic data and it is an official standard of the OGC:
http://www.opengeospatial.org/standards/waterml
I think it's OK if only the getValues() method with an url parameter is supported.
An example WaterML 2.0 request is here:
http://data.fmi.fi/fmi-apikey/1cb8a6f3-d8f4-4ae7-8fc3-0b9449683cfb/wfs?request=getFeature&storedquery_id=fmi::observations::weather::timevaluepair&fmisid=101152&starttime=2013-08-01T00:00:00Z&endtime=2013-08-05T00:00:00Z×tep=60¶meters=temperature
(this is a time-series of air temperature at a station in Finland)
The text was updated successfully, but these errors were encountered: